Migrate to create-plugin and Update package version for grafana-sankey-plugin and grafana-chord-plugin #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #536 +/- ##
==========================================
+ Coverage 70.51% 70.60% +0.09%
==========================================
Files 40 45 +5
Lines 5253 5511 +258
Branches 0 41 +41
==========================================
+ Hits 3704 3891 +187
- Misses 1372 1436 +64
- Partials 177 184 +7
*This pull request uses carry forward flags. Click here to find out more.
|
yuntanghsu
force-pushed
the
migration
branch
5 times, most recently
from
409d129
to
01f0d57
Compare
yuntanghsu
changed the title
|
/theia-test-e2e |
yuntanghsu
force-pushed
the
migration
branch
2 times, most recently
from
7ba260e
to
d440ff9
Compare
heanlan
reviewed
Oct 17, 2023
plugins/grafana-custom-plugins/grafana-chord-plugin/src/ChordPanel.test.tsx
Show resolved
Hide resolved
Dhruv-J
reviewed
Oct 19, 2023
plugins/grafana-custom-plugins/grafana-chord-plugin/.config/Dockerfile
Outdated
Show resolved
Hide resolved
yuntanghsu
force-pushed
the
migration
branch
3 times, most recently
from
c2c06fc
to
9b9a34a
Compare
…y-plugin and grafana-chord-plugin we do: 1. Migration from toolkit to create-plugin for grafana-sankey-plugin and grafana-chord-plugin. 2. Update node version as create-plugin doesn't support node-version < 18. 3. Update @grafana/ui and @grafana/data for grafana-sankey-plugin and grafana-chord-plugin. 4. Update the unit test for grafana-sankey-plugin and grafana-chord-plugin. Note: 1. Couple of dependencies are updated by create-plugin automatically. 2. .config file is generated by create-plugin automatically. 3. Do not update the version of "react" and "react-dom" to the version higher than 16, as we are using enzyme-adapter-react-16. Using version higher than 16 will break the unit test and show error Cannot read property 'child' of undefined 4. The reason we add transformIgnorePatterns in jest.config.js is because we are not using grafana/toolkit to run the test and Jest failed to parse a file. This happens e.g. when our code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax. Signed-off-by: Yun-Tang Hsu <hsuy@vmware.com>
|
/theia-test-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we do:
Reviewer can focus on files [ package.json/jest.config.js/ChordPanel.test.tsx/ChordPanel.tsx/SankeyPanel.tsx]
Note:
Cannot read property 'child' of undefinedGranafa pictures:
