Support ClickHouse Cluster deployment #55

yanjunz97 · 2022-06-21T19:02:58Z

This PR adds support for ClickHouse cluster deployment with shards and replicas.

Signed-off-by: Yanjun Zhou zhouya@vmware.com

yuntanghsu · 2022-06-21T20:00:47Z

Do we need to add podDistribution for clickhouse pod? Like ClickHouseAntiAffinity/ShardAntiAffinity/ReplicaAntiAffinity?

yanjunz97 · 2022-06-22T21:47:46Z

Do we need to add podDistribution for clickhouse pod? Like ClickHouseAntiAffinity/ShardAntiAffinity/ReplicaAntiAffinity?

Thanks Yun-Tang for the suggestion! Add a default podDistribution of type MaxNumberPerNode and allows to be changed in values.yaml.

docs/network-flow-visibility.md

build/charts/theia/README.md

docs/network-flow-visibility.md

heanlan · 2022-06-22T23:55:52Z

docs/network-flow-visibility.md

+3 replicas will be deployed for ClickHouse cluster. Please make sure there are
+at least 3 nodes available in your Kubernetes cluster. To use a customized
+ZooKeeper cluster, please refer the
+[ClickHouse instructions](https://github.com/Altinity/clickhouse-operator/blob/master/docs/zookeeper_setup.md)


I feel the name of the link ClickHouse instructions can be more descriptive/specific, same for L245

Make sense! I update it to ZooKeeper setup instructions for ClickHouse. Please tell me if you have other suggestion, thanks!

docs/network-flow-visibility.md

build/charts/theia/values.yaml

yuntanghsu · 2022-07-06T19:22:59Z

LGTM

build/charts/theia/README.md

build/charts/theia/provisioning/datasources/create_table.sh

build/charts/theia/README.md

build/charts/theia/provisioning/datasources/create_table.sh

build/charts/theia/templates/clickhouse/zookeeper/statefulset.yaml

build/charts/theia/templates/clickhouse/nfs-persistentvolume.yaml

build/charts/theia/values.yaml

docs/network-flow-visibility.md

salv-orlando

Don't have much to add in terms of comments, as the change LGTM.
We need to finalize on our strategy regarding support for non-clustered Clickhouse and then we can finalize this PR.

salv-orlando · 2022-07-29T15:52:05Z

build/charts/theia/README.md

@@ -18,6 +18,14 @@ Kubernetes: `>= 1.16.0-0`

 | Key | Type | Default | Description |
 |-----|------|---------|-------------|
+| clickhouse.cluster.enable | bool | `false` | Determine whether to deploy ClickHouse as a cluster. |


While we discuss on whether we consider non-clustered supported, do you think we can enable clustering by default?

As we plan to deprecate the non-clustered, I think it might be good to remove cluster.enable here and always deploy ClickHouse cluster. Updated as this way.

salv-orlando · 2022-07-29T15:54:29Z

build/charts/theia/README.md

 | clickhouse.storage.createPersistentVolume.local.path | string | `"/data"` | The local path. Required when type is "Local". |
-| clickhouse.storage.createPersistentVolume.nfs.host | string | `""` | The NFS server hostname or IP address. Required when type is "NFS". |
-| clickhouse.storage.createPersistentVolume.nfs.path | string | `""` | The path exported on the NFS server. Required when type is "NFS". |
+| clickhouse.storage.createPersistentVolume.nfs.hosts | list | `[]` | A list of NFS server hostname or IP address. Required when type is "NFS". When ClickHouse clustering is enabled, please provide (shards * replicas) NFS servers. Otherwise, only one NFS server is required. |


I think we're not providing NFS servers but NFS shares, is that correct? They could be for instance all on the same server, mapped to locations assigned to different physical drives.

An NFS share could be defined as nfs.hosts:nfs.path. Do you think this is better to let user input a list of nfs.hosts:nfs.path instead of accepting the two values separately, so that user can use either multiple servers or single server with multiple drives?

Updated as above, thanks

codecov-commenter · 2022-07-29T17:40:20Z

Codecov Report

❗ No coverage uploaded for pull request base (main@4b15e06). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage        ?   24.72%           
=======================================
  Files           ?        9           
  Lines           ?     1278           
  Branches        ?        0           
=======================================
  Hits            ?      316           
  Misses          ?      940           
  Partials        ?       22

Flag	Coverage Δ
unit-tests	`24.72% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b15e06...f5fe273. Read the comment docs.

ziyouw · 2022-08-01T02:14:58Z

build/charts/theia/README.md

@@ -18,6 +18,14 @@ Kubernetes: `>= 1.16.0-0`

 | Key | Type | Default | Description |
 |-----|------|---------|-------------|
+| clickhouse.cluster.enable | bool | `false` | Determine whether to deploy ClickHouse as a cluster. |


ziyouw · 2022-08-01T02:17:41Z

docs/network-flow-visibility.md

+To deploy ClickHouse as a cluster, please set `clickhouse.cluster.enable` to true
+and set `clickhouse.cluster.shards` and `clickhouse.cluster.replicas` per your
+requirement. Please notice that a standlone ClickHouse server cannot switch to
+ClickHouse cluster without deleting. If you plan to scale the ClickHouse cluster


Should we mention that it also will lose data if user wants to switch a cluster to a standalone one?

It makes sense. Added, thanks!

ziyouw · 2022-08-01T02:28:51Z

docs/network-flow-visibility.md

+can deploy multiple replicas in a shard to ensure reliability.
+
+To deploy ClickHouse as a cluster, please set `clickhouse.cluster.enable` to true
+and set `clickhouse.cluster.shards` and `clickhouse.cluster.replicas` per your


We just mainly explained what was shard, but replica is a new term now. Not sure if it is easy for users to understand the relationships between shard and replica.

Added some explanations for replicas. Could you check if it is clearer now? Thank!

docs/network-flow-visibility.md

yanjunz97 · 2022-08-03T17:22:47Z

/theia-test-e2e

yanjunz97 · 2022-08-03T17:46:08Z

/theia-test-e2e

yanjunz97 · 2022-08-03T20:24:50Z

/theia-test-e2e

yanjunz97 · 2022-08-03T21:24:34Z

@salv-orlando @ziyouw I have deprecated the non-cluster mode in this PR and verify the e2e tests. Would you like to take another look at this PR?

salv-orlando

Awesome work, I just have some comments about documentation

docs/network-flow-visibility.md

yanjunz97 · 2022-08-05T23:29:09Z

/theia-test-e2e

docs/network-flow-visibility.md

build/charts/theia/README.md

docs/network-flow-visibility.md

Signed-off-by: Yanjun Zhou <zhouya@vmware.com>

heanlan

LGTM

yuntanghsu

LGTM

yanjunz97 added this to the 0.2 milestone Jun 21, 2022

yanjunz97 force-pushed the clickhouse-cluster branch from 6fe4703 to b42d594 Compare June 21, 2022 19:10

yanjunz97 requested review from dreamtalen, heanlan and salv-orlando June 22, 2022 21:47

dreamtalen reviewed Jun 22, 2022

View reviewed changes

docs/network-flow-visibility.md Outdated Show resolved Hide resolved

docs/network-flow-visibility.md Outdated Show resolved Hide resolved

docs/network-flow-visibility.md Outdated Show resolved Hide resolved

heanlan reviewed Jun 22, 2022

View reviewed changes

yuntanghsu reviewed Jun 24, 2022

View reviewed changes

docs/network-flow-visibility.md Outdated Show resolved Hide resolved

yanjunz97 force-pushed the clickhouse-cluster branch from 3bac901 to a526502 Compare June 24, 2022 17:54

jianjuns reviewed Jun 28, 2022

View reviewed changes

ziyouw reviewed Jul 4, 2022

View reviewed changes

docs/network-flow-visibility.md Outdated Show resolved Hide resolved

docs/network-flow-visibility.md Outdated Show resolved Hide resolved

build/charts/theia/values.yaml Show resolved Hide resolved

yanjunz97 force-pushed the clickhouse-cluster branch from 5bb74fa to 74d037c Compare July 6, 2022 22:13

salv-orlando reviewed Jul 14, 2022

View reviewed changes

yanjunz97 force-pushed the clickhouse-cluster branch 4 times, most recently from 31d50b1 to 851b558 Compare July 21, 2022 23:47

yanjunz97 force-pushed the clickhouse-cluster branch from 851b558 to 427b1d7 Compare July 23, 2022 20:58

salv-orlando reviewed Jul 29, 2022

View reviewed changes

yanjunz97 force-pushed the clickhouse-cluster branch 2 times, most recently from e35793c to f5fe273 Compare July 30, 2022 00:24

ziyouw reviewed Aug 1, 2022

View reviewed changes

yanjunz97 mentioned this pull request Aug 1, 2022

Upload ZooKeeper image #85

Merged

jianjuns reviewed Aug 1, 2022

View reviewed changes

docs/network-flow-visibility.md Outdated Show resolved Hide resolved

yanjunz97 force-pushed the clickhouse-cluster branch 2 times, most recently from 14d8a55 to 7c207a6 Compare August 3, 2022 01:39

yanjunz97 force-pushed the clickhouse-cluster branch from 50b3428 to 6ffcd0f Compare August 3, 2022 17:11

yanjunz97 force-pushed the clickhouse-cluster branch from 6ffcd0f to 27899ff Compare August 3, 2022 17:42

yanjunz97 force-pushed the clickhouse-cluster branch from 27899ff to 1ab3c23 Compare August 3, 2022 20:23

yanjunz97 force-pushed the clickhouse-cluster branch from 1ab3c23 to bb71e47 Compare August 3, 2022 20:44

yanjunz97 requested review from salv-orlando and ziyouw August 3, 2022 21:24

yanjunz97 force-pushed the clickhouse-cluster branch from 254c061 to 769ee74 Compare August 5, 2022 00:08

salv-orlando reviewed Aug 5, 2022

View reviewed changes

docs/network-flow-visibility.md Outdated Show resolved Hide resolved

docs/network-flow-visibility.md Outdated Show resolved Hide resolved

docs/network-flow-visibility.md Outdated Show resolved Hide resolved

yanjunz97 force-pushed the clickhouse-cluster branch 4 times, most recently from 7ae45b7 to 323529c Compare August 5, 2022 22:41

yanjunz97 requested review from yuntanghsu and salv-orlando August 5, 2022 23:28

yuntanghsu reviewed Aug 8, 2022

View reviewed changes

docs/network-flow-visibility.md Show resolved Hide resolved

yanjunz97 force-pushed the clickhouse-cluster branch from 6431c20 to 0f093f6 Compare August 8, 2022 19:07

salv-orlando approved these changes Aug 8, 2022

View reviewed changes

yanjunz97 force-pushed the clickhouse-cluster branch from 0f093f6 to eb92fc5 Compare August 8, 2022 20:42

heanlan approved these changes Aug 8, 2022

View reviewed changes

build/charts/theia/README.md Outdated Show resolved Hide resolved

docs/network-flow-visibility.md Outdated Show resolved Hide resolved

Support ClickHouse Cluster deployment

aab4cc6

Signed-off-by: Yanjun Zhou <zhouya@vmware.com>

yanjunz97 force-pushed the clickhouse-cluster branch from eb92fc5 to aab4cc6 Compare August 8, 2022 22:59

heanlan approved these changes Aug 8, 2022

View reviewed changes

yuntanghsu approved these changes Aug 8, 2022

View reviewed changes

ziyouw approved these changes Aug 9, 2022

View reviewed changes

yanjunz97 merged commit 13d92c9 into antrea-io:main Aug 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support ClickHouse Cluster deployment #55

Support ClickHouse Cluster deployment #55

yanjunz97 commented Jun 21, 2022

yuntanghsu commented Jun 21, 2022

yanjunz97 commented Jun 22, 2022

heanlan Jun 22, 2022

yanjunz97 Jun 23, 2022

yuntanghsu commented Jul 6, 2022

salv-orlando left a comment

salv-orlando Jul 29, 2022

ziyouw Aug 1, 2022

yanjunz97 Aug 2, 2022

salv-orlando Jul 29, 2022

yanjunz97 Jul 29, 2022 •

edited

Loading

yanjunz97 Jul 30, 2022

codecov-commenter commented Jul 29, 2022 •

edited

Loading

ziyouw Aug 1, 2022

ziyouw Aug 1, 2022

yanjunz97 Aug 2, 2022

ziyouw Aug 1, 2022

yanjunz97 Aug 2, 2022

yanjunz97 commented Aug 3, 2022

yanjunz97 commented Aug 3, 2022

yanjunz97 commented Aug 3, 2022

yanjunz97 commented Aug 3, 2022

salv-orlando left a comment

yanjunz97 commented Aug 5, 2022

heanlan left a comment

yuntanghsu left a comment

Support ClickHouse Cluster deployment #55

Support ClickHouse Cluster deployment #55

Conversation

yanjunz97 commented Jun 21, 2022

yuntanghsu commented Jun 21, 2022

yanjunz97 commented Jun 22, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yuntanghsu commented Jul 6, 2022

salv-orlando left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yanjunz97 Jul 29, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Jul 29, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yanjunz97 commented Aug 3, 2022

yanjunz97 commented Aug 3, 2022

yanjunz97 commented Aug 3, 2022

yanjunz97 commented Aug 3, 2022

salv-orlando left a comment

Choose a reason for hiding this comment

yanjunz97 commented Aug 5, 2022

heanlan left a comment

Choose a reason for hiding this comment

yuntanghsu left a comment

Choose a reason for hiding this comment

yanjunz97 Jul 29, 2022 •

edited

Loading

codecov-commenter commented Jul 29, 2022 •

edited

Loading