Add Thiea Manager with basic functionality #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsquan171
force-pushed
the
manager
branch
2 times, most recently
from
cbc4a8b
to
e3cf6a4
Compare
yuntanghsu
reviewed
Aug 24, 2022
wsquan171
force-pushed
the
manager
branch
3 times, most recently
from
7e42527
to
ba3ae5f
Compare
yuntanghsu
reviewed
Aug 25, 2022
yanjunz97
reviewed
Aug 26, 2022
yuntanghsu
reviewed
Aug 26, 2022
| Namespace: npReco.Namespace, | ||
| Name: npReco.Name, | ||
| } | ||
| c.queue.Add(namespacedName) |
There was a problem hiding this comment.
Should it be c.queue.forget(namespacedName)?
There was a problem hiding this comment.
c.queue is the actual worker queue to reconcile the resources. here we're just adding the key to the workqueue to indicate that some resource is removed and reconciliation is needed (i.e. deletion of child res related to this job CR). the key is forgotten only when reconciliation is done for it.
wsquan171
force-pushed
the
manager
branch
2 times, most recently
from
c03db5d
to
829a288
Compare
dreamtalen
reviewed
Aug 26, 2022
cmd/theia-manager/theia-manager.go
Outdated
| const informerDefaultResync = 12 * time.Hour | ||
|
|
||
| func run(o *Options) error { | ||
| klog.Infof("Theia manager starting...") |
There was a problem hiding this comment.
better to use structured logging: klog.InfoS(). Same for other logs.
There was a problem hiding this comment.
fixed 4 occurrences
pkg/apiserver/apiserver.go
Outdated
| } | ||
| p := s.GenericAPIServer | ||
| if p == nil { | ||
| return fmt.Errorf("nil") |
There was a problem hiding this comment.
removed both. was leftover when doing local debugging. neither should be the case when actually running the code.
wsquan171
force-pushed
the
manager
branch
2 times, most recently
from
7e737bd
to
9fde85d
Compare
This change adds the following: 1. API server setup and config 2. sample REST endpoint apis/intelligence.theia.antrea.io/v1alpha1/networkpolicyrecommendations 3. codegen scripts for API server 4. helm charts for theia Manager and API server config values Signed-off-by: Shawn Wang <wshaoquan@vmware.com>
This change adds an example controller to Theia manager, which watches
NetworkPolicyRecommendation and exposes querier interface for APIServer
to consume.
When NetworkPolicyRecommendation is deployed in flow-visibility NS,
the k8s resources and be properly returned via REST endpoint
/apis/intelligence.theia.antrea.io/v1alpha1/networkpolicyrecommendations/{name}
Signed-off-by: Shawn Wang <wshaoquan@vmware.com>
Signed-off-by: Shawn Wang <wshaoquan@vmware.com>
yuntanghsu
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the skeleton of Theia manager, including APIServer and a simple
NetworkPolicyRecommendationCR controller.The code is structured following Antrea controller, and summarized below:
pkg/apis/crdstructured CRD definitions for k8s client generation (consumed by controllers)pkg/apis/intelligencestructured REST payload definitions by API group and endpointspkg/apiserver/registryREST handlers grouped by API group and endpointspkg/apiserver/apiserver.goAPIServer definitions and configurationspkg/clientk8s client-gen'ed codespkg/controllercollection of k8s resource controllersThis change also adds Helm chart generation and code generation scripts.
To get the manager up and running in an existing testbed:
build/charts/theia/crds/network-policy-recommendation-crd.yamlmake theia-managerand scp imageprojects.registry.vmware.com/antrea/theia-manager:latestto worker nodeshack/generate-manifest.sh --mode dev --theia-manager > build/yamls/flow-visibility.ymland apply the diffsWith the following CR deployed:
$ curl -k https://<theia-manager-svc>/apis/intelligence.theia.antrea.io/v1alpha1/networkpolicyrecommendations/pr-testcurl -k https://<theia-manager-svc>apis/intelligence.theia.antrea.io/v1alpha1/networkpolicyrecommendations/pr-test-1