Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export constants like: view-life-circle #3281

Merged
merged 1 commit into from
Feb 8, 2021
Merged

feat: export constants like: view-life-circle #3281

merged 1 commit into from
Feb 8, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Feb 8, 2021

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@visiky visiky requested a review from hustcc February 8, 2021 03:36
hustcc
hustcc reviewed Feb 8, 2021
View reviewed changes
src/index.ts
@@ -676,4 +676,7 @@ declare module './chart/view' {
}
}

// 暴露一些常量
export { VIEW_LIFE_CIRCLE } from './constant';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接用 G2. VIEW_LIFE_CIRCLE 可以吗？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

类似，G2.Util 搞一个 G2.Constant ?

@github-actions
Copy link

github-actions bot commented Feb 8, 2021 •
edited
Loading

😭 Deploy PR Preview 5fb182d failed. Build logs

🤖 By surge-preview

@visiky visiky mentioned this pull request Feb 8, 2021
Merged
6 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 546765453

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0008%) to 93.516%
Totals Coverage Status
Change from base Build 546596250: 0.0008%
Covered Lines: 10842
Relevant Lines: 11248
💛 - Coveralls

@hustcc hustcc merged commit d0f96c4 into master Feb 8, 2021
@hustcc hustcc deleted the export-constant branch February 8, 2021 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visiky @coveralls @hustcc