Skip to content

Commit

Permalink
fix(#1882): add limitInPoit as default options
Browse files Browse the repository at this point in the history
  • Loading branch information
hustcc committed Nov 9, 2020
1 parent 4e7e022 commit e43923f
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 0 deletions.
37 changes: 37 additions & 0 deletions __tests__/bugs/issue-1882-spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import { Area } from '../../src';
import { createDiv } from '../utils/dom';

describe('#1882', () => {
const data = [
{ year: '1991', value: 3 },
{ year: '1992', value: 4 },
{ year: '1993', value: 3.5 },
{ year: '1994', value: 5 },
{ year: '1995', value: 4.9 },
{ year: '1996', value: 6 },
{ year: '1997', value: 7 },
{ year: '1998', value: 9 },
{ year: '1999', value: 13 },
];
it('limit in Plot', () => {
const area = new Area(createDiv('limitInPlot'), {
data,
height: 500,
width: 600,
xField: 'year',
yField: 'value',
yAxis: {
min: 10,
},
});

area.render();

expect(area.chart.limitInPlot).toBe(true);
expect(area.chart.middleGroup.get('clipShape')).toBeDefined();
// 大于一个 xAxis 的高度
expect(area.chart.middleGroup.get('clipShape').getBBox().minY > 5).toBe(true);

area.destroy();
});
});
2 changes: 2 additions & 0 deletions src/core/plot.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ export abstract class Plot<O extends PickOptions> extends EE {
localRefresh: false, // 默认关闭,目前 G 还有一些位置问题,难以排查!
syncViewPadding,
supportCSSTransform,
/** 图形不超出画布 */
limitInPlot: true,
});
}

Expand Down

0 comments on commit e43923f

Please sign in to comment.