Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(line): add line options #1291

Merged
merged 5 commits into from
Jul 17, 2020
Merged

feat(line): add line options #1291

merged 5 commits into from
Jul 17, 2020

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Jul 15, 2020 •
edited
Loading

line:

  • style
  • tooltip
  • label
  • smooth
  • shape
  • point
  • scrollbar
  • slider
  • mark point, line
  • animate

@hustcc hustcc requested review from visiky and lxfu1 July 15, 2020 02:14
@auto-add-label auto-add-label bot added the enhancement New feature or request label Jul 15, 2020
tests-checker[bot]
tests-checker bot suggested changes Jul 15, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@hustcc hustcc changed the title feat(line): add style, tooltip options feat(line): add line options Jul 15, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jul 15, 2020

This pull request introduces 1 alert when merging a2cc65b into f7b68f8 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jul 15, 2020

This pull request introduces 1 alert when merging ed8153b into f7b68f8 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@hustcc hustcc added this to the v2 milestone Jul 15, 2020
@hustcc hustcc added the v2 label Jul 15, 2020
visiky
visiky reviewed Jul 15, 2020
View reviewed changes
src/common/adaptor.ts Show resolved Hide resolved
src/plots/line/adaptor.ts Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Jul 16, 2020

This pull request fixes 1 alert when merging 768a8e0 into f7b68f8 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@hustcc hustcc requested a review from visiky July 17, 2020 09:49
@lgtm-com
Copy link

lgtm-com bot commented Jul 17, 2020

This pull request fixes 1 alert when merging e7171ec into f7b68f8 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@visiky visiky merged commit e2ee437 into v2 Jul 17, 2020
@visiky visiky deleted the feat-line-style branch July 17, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

@visiky visiky visiky approved these changes

@lxfu1 lxfu1 Awaiting requested review from lxfu1

Assignees
No one assigned
Labels
enhancement New feature or request PR: merged v2
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.
2 participants
@hustcc @visiky