feat: new chart type - heatmap #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
v2-heatmap
branch
from
3d7354a to
862b800
Compare
hustcc
reviewed
Aug 3, 2020
hustcc
reviewed
Aug 3, 2020
hustcc
reviewed
Aug 3, 2020
hustcc
reviewed
Aug 5, 2020
|
色块图的图例：size/color 是否同时展示这个，建议先按照 G2 默认的规则来，一般只要符合映射就会默认展示的。至于后续的展示方案可以再确定，很有可能需要定制 |
hustcc
reviewed
Aug 5, 2020
* rename `shape` to `shapeType` to be consistent with 1.x * optimized the implementation of heatmap adaptor * add tuple type function * add test cases size-spec
hustcc
reviewed
Aug 6, 2020
hustcc
approved these changes
Aug 6, 2020
BBSQQ
pushed a commit
that referenced
this pull request
Aug 25, 2020
* feat: new chart type - heatmap * feat: heatmap axis and shape * feat: shape and size * feat: new chart type - heatmap * feat: heatmap axis and shape * feat: shape and size * feat: heatmapStyle * fix: merge v2 * fix: resolve test case * fix: value map to size * feat: sizeRatio and some optimization * rename `shape` to `shapeType` to be consistent with 1.x * optimized the implementation of heatmap adaptor * add tuple type function * add test cases size-spec * fix: temporarily cancel legend * fix: test cases with semantic test dataset
BBSQQ
pushed a commit
that referenced
this pull request
Aug 25, 2020
* feat: new chart type - heatmap * feat: heatmap axis and shape * feat: shape and size * feat: new chart type - heatmap * feat: heatmap axis and shape * feat: shape and size * feat: heatmapStyle * fix: merge v2 * fix: resolve test case * fix: value map to size * feat: sizeRatio and some optimization * rename `shape` to `shapeType` to be consistent with 1.x * optimized the implementation of heatmap adaptor * add tuple type function * add test cases size-spec * fix: temporarily cancel legend * fix: test cases with semantic test dataset
BBSQQ
pushed a commit
that referenced
this pull request
Aug 25, 2020
* feat: new chart type - heatmap * feat: heatmap axis and shape * feat: shape and size * feat: new chart type - heatmap * feat: heatmap axis and shape * feat: shape and size * feat: heatmapStyle * fix: merge v2 * fix: resolve test case * fix: value map to size * feat: sizeRatio and some optimization * rename `shape` to `shapeType` to be consistent with 1.x * optimized the implementation of heatmap adaptor * add tuple type function * add test cases size-spec * fix: temporarily cancel legend * fix: test cases with semantic test dataset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To discuss
heatmap 的图例应该不包含离散类型，可以不需要。
size legend lostsize、color 两个图例需要同时存在吗？: 需要以后 G2 解决，先取消图例
在 G2 的 repo 开了一个 关于 size 直接映射到面积的issue
如果确认的话，我这部分映射要稍微改下（目前是和 G2 同步的，大多是size映射到半径）