feat(v2/column): extract common interval geometry #1391
Merged
+127
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
liuzhenying
reviewed
Aug 4, 2020
| readonly style?: ShapeStyle | ((x: any, y: any, color?: any) => ShapeStyle); | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
- 可以把 interval 单独抽出成一个 type 吗，类似这种 https://github.com/antvis/G2Plot/blob/v2_feat_combo/src/adaptor/geometries/line.ts
- 这个配置应该是已经确定了吧，isGroup， groupField 等
- 其他的可以满足需求
There was a problem hiding this comment.
interval 就是一个单独的 geometry type 了，看48行
hustcc
reviewed
Aug 4, 2020
| const { stackField, seriesField, colorField } = options; | ||
|
|
||
| return stackField || seriesField || colorField; | ||
| } |
There was a problem hiding this comment.
这两个属于 util 方法，放到 plots/bar/ 中？如果外面不需要用，就不 export 出去，作为这个文件的内部方法
hustcc
approved these changes
Aug 4, 2020
BBSQQ
pushed a commit
that referenced
this pull request
Aug 25, 2020
* feat(v2/column): extract common interval geometry * feat(v2/column): remove unnecessary exports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@liuzhenying 看下能满足双轴图要求不