增加饼、环图文档 ，同时补全饼图能力 #1411
Merged
增加饼、环图文档 ，同时补全饼图能力 #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
statistic 增加title 和 content boolean 类型,允许显式关闭
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
- 移除 radius 默认配置
hustcc
reviewed
Aug 10, 2020
hustcc
reviewed
Aug 10, 2020
| } | ||
| return isNil(actualOffset) || actualOffset > 0 ? -(radius - innerRadius) * 0.3 : actualOffset; | ||
| } | ||
| } |
There was a problem hiding this comment.
确定给 G2 label offset 增加 string 百分比类型是吧？（仅供 pie 使用）
visiky
commented
Aug 10, 2020
| if (isString(actualOffset)) { | ||
| actualOffset = (radius - innerRadius) * parsePercentageToNumber(actualOffset); | ||
| } | ||
| return isNil(actualOffset) || actualOffset > 0 ? -(radius - innerRadius) * 0.3 : actualOffset; |
There was a problem hiding this comment.
当 offset 没设置或者大于 0 时，默认去 30% 偏移
There was a problem hiding this comment.
嗯，先提供经验值，后面我加上备注；还有一些优化的地方
hustcc
approved these changes
Aug 10, 2020
BBSQQ
pushed a commit
that referenced
this pull request
Aug 25, 2020
* feat(v2/core): 增加 default cfg 配置 * feat(v2/legend-adaptor): 增加通用 legend adaptor, 修复 饼图 legend 关闭失效 * feat(v2/pie-inner-label): 增加 pie-inner label 类型 & 增 强 statistic statistic 增加title 和 content boolean 类型,允许显式关闭 * test: 增加测试用例 * docs(v2/pie): 增加饼/环 demo & api 文档 - 移除 radius 默认配置
BBSQQ
pushed a commit
that referenced
this pull request
Aug 25, 2020
* feat(v2/core): 增加 default cfg 配置 * feat(v2/legend-adaptor): 增加通用 legend adaptor, 修复 饼图 legend 关闭失效 * feat(v2/pie-inner-label): 增加 pie-inner label 类型 & 增 强 statistic statistic 增加title 和 content boolean 类型,允许显式关闭 * test: 增加测试用例 * docs(v2/pie): 增加饼/环 demo & api 文档 - 移除 radius 默认配置
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pie-innerlabel 类型