Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(state): 添加 setState 方法,通过条件设置三种状态的激活与否 #1460

Merged
merged 5 commits into from
Aug 19, 2020

Conversation

visiky
Copy link
Member

@visiky visiky commented Aug 19, 2020

先看下思路,没问题再补充:文档、测试用例、接入到每个 plot 中

others

默认状态(后续再考虑,现状业务层自己可以满足)
组件联动(设置状态的时候,联动 tooltip、legend、axis 等,是否必须,待定)

checklist

  • methods: setState & getStates
  • demo
  • testcases
  • docs

@auto-add-label auto-add-label bot added the enhancement New feature or request label Aug 19, 2020
@visiky visiky requested review from hustcc, lessmost and lxfu1 August 19, 2020 00:33
src/core/plot.ts Outdated Show resolved Hide resolved
src/core/plot.ts Outdated Show resolved Hide resolved
src/adaptor/common.ts Outdated Show resolved Hide resolved
src/core/plot.ts Outdated Show resolved Hide resolved
src/core/plot.ts Outdated Show resolved Hide resolved
src/types/state.ts Outdated Show resolved Hide resolved
src/core/plot.ts Outdated Show resolved Hide resolved
src/core/plot.ts Outdated Show resolved Hide resolved
@hustcc hustcc self-requested a review August 19, 2020 05:01
@hustcc hustcc merged commit 5ba9e0a into master Aug 19, 2020
@hustcc hustcc deleted the add-state branch August 19, 2020 05:04
BBSQQ pushed a commit that referenced this pull request Aug 25, 2020
* feat(state): 添加 setState 方法,通过条件设置三种状态的激活与否

- [x] demo
- [ ] testcases
- [ ] docs

* feat(state): 添加 setState & getStates 方法,通过条件设置三种状态的激活与否

- [x] demo
- [ ] testcases
- [ ] docs

* refactor: 修改 cr 建议

* refactor: 修改 cr 建议 & 添加测试用例

* fix(pie-statistic): 修复中心文本类型定义 & 样式问题
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants