Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(indicator): when indicator > 1 or < 0 in gauge, progress, ring #1673

Merged
merged 2 commits into from
Sep 29, 2020
Merged

fix(indicator): when indicator > 1 or < 0 in gauge, progress, ring #1673

merged 2 commits into from
Sep 29, 2020

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Sep 29, 2020

  • fix style when indicator > 1 or < 0
  • gauge
  • ring
  • progress

@auto-add-label auto-add-label bot added the Bug Something isn't working label Sep 29, 2020
@hustcc hustcc mentioned this pull request Sep 29, 2020
Closed
@hustcc hustcc requested a review from lxfu1 September 29, 2020 13:33
lxfu1
lxfu1 reviewed Sep 29, 2020
View reviewed changes
src/plots/gauge/adaptor.ts Outdated Show resolved Hide resolved
@hustcc hustcc merged commit 86f110b into master Sep 29, 2020
@hustcc hustcc deleted the fix-indicator-gt-1 branch September 29, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxfu1 lxfu1 lxfu1 left review comments

Assignees
No one assigned
Labels
Bug Something isn't working PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hustcc @lxfu1