-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(word-cloud): fix tooltip and add demo for custom tooltip #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎊 PR Preview 187a8d7 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-1762.surge.sh 🕐 Build time: 593.082s 🤖 By surge-preview |
lxfu1
reviewed
Oct 21, 2020
zhangzhonghe
force-pushed
the
fix-1754
branch
from
October 21, 2020 12:03
c7a6abc
to
b908c87
Compare
hustcc
reviewed
Oct 21, 2020
@zhangzhonghe bugfix 的 pr,可以参考 #1764 。 单测写到 bugs 目录中,然后单测命名以 issue-id-spec.ts 命名,后面容易追溯。。 |
zhangzhonghe
force-pushed
the
fix-1754
branch
2 times, most recently
from
October 21, 2020 13:30
e5f5e8a
to
0961c52
Compare
hustcc
reviewed
Oct 21, 2020
hustcc
reviewed
Oct 22, 2020
hustcc
reviewed
Oct 22, 2020
zhangzhonghe
force-pushed
the
fix-1754
branch
from
October 22, 2020 09:35
e87f77c
to
1dd3465
Compare
zhangzhonghe
force-pushed
the
fix-1754
branch
from
October 22, 2020 09:47
1dd3465
to
4ef598b
Compare
hustcc
reviewed
Oct 22, 2020
hustcc
reviewed
Oct 22, 2020
antvis/G2#2945 相关 PR 先如下修改(等上面的 PR 合并之后,更新 G2 版本,即可生效): seriesField: colorField && 'color',
fill: cfg.color || cfg.defaultStyle.fill, |
OK |
zhangzhonghe
force-pushed
the
fix-1754
branch
from
October 22, 2020 13:38
bf85063
to
d1aef04
Compare
hustcc
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #1754
修复之后的 tooltip 样式: