Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(word-cloud): fix tooltip and add demo for custom tooltip #1762

Merged
merged 9 commits into from
Oct 22, 2020
Merged

Conversation

zhangzhonghe
Copy link
Member

@zhangzhonghe zhangzhonghe commented Oct 21, 2020

fixed #1754

  • 修复词语颜色不对
  • 修复tooltip显示坐标值而不是权重的问题,通过添加一个默认的tooltip
  • 添加一个自定义tooltip的示例
  • 新增一个colorField配置项,方便更改颜色映射
  • 添加1754单侧

修复之后的 tooltip 样式:
CF7C4D5F-4A73-4085-B45D-543ED3DC8443

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2020

🎊 PR Preview 187a8d7 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-1762.surge.sh

🕐 Build time: 593.082s

🤖 By surge-preview

@hustcc
Copy link
Member

hustcc commented Oct 21, 2020

@zhangzhonghe bugfix 的 pr,可以参考 #1764

单测写到 bugs 目录中,然后单测命名以 issue-id-spec.ts 命名,后面容易追溯。。

@zhangzhonghe zhangzhonghe force-pushed the fix-1754 branch 2 times, most recently from e5f5e8a to 0961c52 Compare October 21, 2020 13:30
@hustcc
Copy link
Member

hustcc commented Oct 22, 2020

antvis/G2#2945 相关 PR

先如下修改(等上面的 PR 合并之后,更新 G2 版本,即可生效):

seriesField: colorField && 'color',

fill: cfg.color || cfg.defaultStyle.fill,

@zhangzhonghe
Copy link
Member Author

antvis/G2#2945 相关 PR

先如下修改(等上面的 PR 合并之后,更新 G2 版本,即可生效):

seriesField: colorField && 'color',

fill: cfg.color || cfg.defaultStyle.fill,

OK

@hustcc hustcc merged commit 187a8d7 into master Oct 22, 2020
@hustcc hustcc deleted the fix-1754 branch October 22, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V2 Wordcloud tooltip is displaying coordinates instead of weight
3 participants