Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1882): add limitInPoit options for G2.Chart #1885

Merged
merged 1 commit into from
Nov 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions __tests__/bugs/issue-1882-spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import { Area } from '../../src';
import { createDiv } from '../utils/dom';

describe('#1882', () => {
const data = [
{ year: '1991', value: 3 },
{ year: '1992', value: 4 },
{ year: '1993', value: 3.5 },
{ year: '1994', value: 5 },
{ year: '1995', value: 4.9 },
{ year: '1996', value: 6 },
{ year: '1997', value: 7 },
{ year: '1998', value: 9 },
{ year: '1999', value: 13 },
];
it('limit in Plot', () => {
const area = new Area(createDiv('limitInPlot'), {
data,
height: 500,
width: 600,
xField: 'year',
yField: 'value',
yAxis: {
min: 10,
},
});

area.render();

expect(area.chart.limitInPlot).toBe(true);
expect(area.chart.middleGroup.get('clipShape')).toBeDefined();
// 大于一个 xAxis 的高度
expect(area.chart.middleGroup.get('clipShape').getBBox().minY > 5).toBe(true);

area.destroy();
});
});
2 changes: 2 additions & 0 deletions src/core/plot.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ export abstract class Plot<O extends PickOptions> extends EE {
localRefresh: false, // 默认关闭,目前 G 还有一些位置问题,难以排查!
syncViewPadding,
supportCSSTransform,
/** 图形不超出画布 */
limitInPlot: true,
});
}

Expand Down