Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: auto set limitInPlot based on yAxis config #2009

Merged
merged 2 commits into from
Nov 25, 2020
Merged

feat: auto set limitInPlot based on yAxis config #2009

merged 2 commits into from
Nov 25, 2020

Conversation

lessmost
Copy link
Member

yAxis 没有设置 min/max 的时候 自动设置 limitInPlot 为false，否则设置为 true

@lessmost lessmost requested review from visiky and hustcc November 25, 2020 03:31
@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2020 •
edited
Loading

😭 Deploy PR Preview 24051f5 failed. Build logs

🤖 By surge-preview

@lessmost lessmost requested a review from lxfu1 November 25, 2020 03:31
@coveralls
Copy link

coveralls commented Nov 25, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 382487555

  • 12 of 12 (100.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 96.712%
Files with Coverage Reduction New Missed Lines %
src/utils/transform/word-cloud.ts 1 97.75%
Totals Coverage Status
Change from base Build 382319392: 0.09%
Covered Lines: 3961
Relevant Lines: 3996
💛 - Coveralls

@hustcc
Copy link
Member

hustcc commented Nov 25, 2020

如果外部强制设置 limitPlot 了，优先级是最该吗？

@lessmost
Copy link
Member Author

lessmost commented Nov 25, 2020 •
edited
Loading

如果外部强制设置 limitPlot 了，优先级是最该吗？

对，用户的设置优先级最高，自动逻辑只有用户没有设置才生效

@hustcc hustcc merged commit c4a1794 into master Nov 25, 2020
@hustcc hustcc deleted the feat-auto-limtInPLot branch November 25, 2020 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

@visiky visiky Awaiting requested review from visiky

@lxfu1 lxfu1 Awaiting requested review from lxfu1

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lessmost @coveralls @hustcc