Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only enable tooltip for primary geometry for line/area/radar #2087

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

lessmost
Copy link
Member

@lessmost lessmost commented Dec 8, 2020

修复折线上图上 tooltip 有时会出现重复的 tooltip items,原因为多个 geometry 的 tooltip 同时显示出来了:

before after
image image

@lessmost lessmost requested review from hustcc and visiky December 8, 2020 15:43
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

😭 Deploy PR Preview 29cc2f9 failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

Pull Request Test Coverage Report for Build 408577520

  • 11 of 11 (100.0%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 96.686%

Files with Coverage Reduction New Missed Lines %
src/plots/line/adaptor.ts 2 94.44%
Totals Coverage Status
Change from base Build 408035756: 0.003%
Covered Lines: 4166
Relevant Lines: 4203

💛 - Coveralls

@visiky
Copy link
Member

visiky commented Dec 8, 2020

看起来没啥问题,geometry options 变量是否是否可以简写为: p(primary) s(second)

@hustcc
Copy link
Member

hustcc commented Dec 9, 2020

和 label 一样的逻辑

@hustcc hustcc merged commit c006f46 into master Dec 9, 2020
@hustcc hustcc deleted the fix-duplicate-tooltip branch December 9, 2020 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants