-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: changedata #2142
Merged
Merged
feat: changedata #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
😭 Deploy PR Preview b7f29b5 failed. Build logs 🤖 By surge-preview |
visiky
force-pushed
the
feat-changedata
branch
from
December 25, 2020 07:06
15c53c3
to
e08c2c6
Compare
Pull Request Test Coverage Report for Build 448693133
💛 - Coveralls |
visiky
force-pushed
the
feat-changedata
branch
from
December 28, 2020 06:59
c829ba7
to
ff8f641
Compare
- overrider changedata - provide demo
- 抽取获取 view data 的工具方法 - override changeData
visiky
force-pushed
the
feat-changedata
branch
from
December 28, 2020 07:06
ff8f641
to
3e12a20
Compare
visiky
force-pushed
the
feat-changedata
branch
3 times, most recently
from
December 28, 2020 08:38
55df449
to
7dd1a12
Compare
visiky
force-pushed
the
feat-changedata
branch
from
December 28, 2020 09:25
7dd1a12
to
b360551
Compare
hustcc
reviewed
Dec 28, 2020
src/plots/gauge/constant.ts
Outdated
@@ -3,3 +3,7 @@ export const RANGE_TYPE = 'type'; | |||
export const PERCENT = 'percent'; | |||
|
|||
export const DEFAULT_COLOR = '#f0f0f0'; | |||
|
|||
/** 仪表盘由 指针和表盘 组成 */ | |||
export const INDICATEOR_VIEW_ID = 'indicator_view'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indicator-view
直接用中划线吧,其他的这种常量命名都是这个规则。
hustcc
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions
changeData
api 来更新数据,每个 plot 复写 core 的changeData
方法(后续全面迁移完成后,设置为抽象方法)core/plot
提供updateOption
方法Screenshot