Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: column and bar plot support pixel width setting #2156

Merged
merged 4 commits into from
Dec 29, 2020
Merged

feat: column and bar plot support pixel width setting #2156

merged 4 commits into from
Dec 29, 2020

Conversation

visiky
Copy link
Member

@visiky visiky commented Dec 29, 2020 •
edited
Loading

PR includes

Column plot supports minColumnWidth and maxColumnWidth, and bar plot supports minBarWidth and maxBarWidth. With this feature, you can set pixel column or bar width.

Screenshot

Before After
❌ ✅

@visiky visiky requested a review from hustcc December 29, 2020 08:17
@visiky visiky changed the title column and bar plot feat: column and bar plot support pixel width setting Dec 29, 2020
@visiky visiky requested review from lessmost and lxfu1 December 29, 2020 08:23
@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2020 •
edited
Loading

😭 Deploy PR Preview 06bccff failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

coveralls commented Dec 29, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 450410905

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.771%
Totals Coverage Status
Change from base Build 450390489: 0.0%
Covered Lines: 4408
Relevant Lines: 4446
💛 - Coveralls

@hustcc hustcc merged commit db09fa4 into master Dec 29, 2020
@hustcc hustcc deleted the column-width branch December 29, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

@lessmost lessmost Awaiting requested review from lessmost

@lxfu1 lxfu1 Awaiting requested review from lxfu1

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question: Column gap
3 participants
@visiky @coveralls @hustcc