Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 玫瑰图修改 changeData && 添加单测 #2200

Merged
merged 2 commits into from
Jan 11, 2021
Merged

feat: 玫瑰图修改 changeData && 添加单测 #2200

merged 2 commits into from
Jan 11, 2021

Conversation

yp0413150120
Copy link
Contributor

PR includes

override the changeData method of rose plot

  • add / modify test cases

@visiky visiky self-requested a review January 11, 2021 09:34
@coveralls
Copy link

coveralls commented Jan 11, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 477197789

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 96.89%
Totals Coverage Status
Change from base Build 475445161: 0.03%
Covered Lines: 4556
Relevant Lines: 4593
💛 - Coveralls

visiky
visiky approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@visiky visiky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG；

@visiky visiky added this to the change-data milestone Jan 11, 2021
@visiky visiky merged commit eb44c0f into antvis:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky visiky approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
change-data
Development

Successfully merging this pull request may close these issues.
3 participants
@yp0413150120 @coveralls @visiky