Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(bullet): 子弹图升级下 & 修复 axis 配置失效 #2228

Merged
merged 7 commits into from
Jan 17, 2021
Merged

refactor(bullet): 子弹图升级下 & 修复 axis 配置失效 #2228

merged 7 commits into from
Jan 17, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Jan 16, 2021 •
edited
Loading

PR includes

  • fixed 子弹图 axis 在没有配置 meta 的时候，axis 配置失效
  • add / modify test cases
  • documents, demos
  • default: 默认关闭 tooltip 的 showMarkers

Screenshot

Before After
image image

图表指引内容

image

@visiky
refactor(bullet): 重构下子弹图的 adaptor
4a00776 
使用通用的 scale adaptor 来处理
fix: 修复子弹图 axis 在没有配置 meta 的时候，axis配置如 tickCount 等失效
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2021 •
edited
Loading

😭 Deploy PR Preview 5c1ec2b failed. Build logs

🤖 By surge-preview

visiky added 2 commits January 16, 2021 15:32
@visiky
docs(demo): 子弹图 demo 的优化
c26861c
@visiky
docs(bullet): 子弹图 api 文档优化
54ea8da 
目前 color 应该只支持 string 或 string[], 不支持回调
@coveralls
Copy link

coveralls commented Jan 16, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 490231826

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 96.877%
Totals Coverage Status
Change from base Build 483114834: -0.03%
Covered Lines: 4577
Relevant Lines: 4614
💛 - Coveralls

@visiky visiky changed the title refactor(bullet): 子弹图升级下 & 修复 axis 配置失效' refactor(bullet): 子弹图升级下 & 修复 axis 配置失效 Jan 16, 2021
@visiky visiky requested review from lxfu1 and hustcc January 16, 2021 13:44
@hustcc hustcc merged commit 8ac5549 into master Jan 17, 2021
@hustcc hustcc deleted the bullet-updated branch January 17, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

@lxfu1 lxfu1 Awaiting requested review from lxfu1

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visiky @coveralls @hustcc