Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(change-data): 饼图支持动态更新数据 & 其他若干处理，见 PR 描述 #2257

Merged
merged 9 commits into from
Jan 24, 2021
Merged

feat(change-data): 饼图支持动态更新数据 & 其他若干处理，见 PR 描述 #2257

merged 9 commits into from
Jan 24, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Jan 22, 2021 •
edited
Loading

PR includes

Screenshot

Before After
动态更新数据-pie-before 动态更新数据-pie-after
饼图中心文本从展示到隐藏再展示后，样式丢失
image image

@visiky visiky added the WIP label Jan 22, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2021 •
edited
Loading

😭 Deploy PR Preview c5900c1 failed. Build logs

🤖 By surge-preview

@visiky visiky changed the title feat(change-data): 饼图支持动态更新数据 feat(change-data): 饼图支持动态更新数据 & defaultOptions 处理 Jan 23, 2021
@visiky visiky removed the WIP label Jan 23, 2021
@visiky visiky requested review from hustcc, lxfu1 and liuzhenying and removed request for hustcc January 23, 2021 03:55
@visiky visiky changed the title feat(change-data): 饼图支持动态更新数据 & defaultOptions 处理 feat(change-data): 饼图支持动态更新数据 & 其他若干处理，见 PR 描述 Jan 23, 2021
@visiky visiky force-pushed the pie-change-data branch 4 times, most recently from 2e9add6 to e741d0c Compare January 24, 2021 01:28
@coveralls
Copy link

coveralls commented Jan 24, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 506873812

  • 43 of 47 (91.49%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 96.751%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/plots/pie/index.ts 13 17 76.47%
Files with Coverage Reduction New Missed Lines %
src/plots/pie/adaptor.ts 1 94.02%
Totals Coverage Status
Change from base Build 506854947: -0.06%
Covered Lines: 4638
Relevant Lines: 4680
💛 - Coveralls

hustcc
hustcc approved these changes Jan 24, 2021
View reviewed changes
Copy link
Member

@hustcc hustcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

默认配置改静态方法可以统一一波干掉。

@hustcc
Copy link
Member

hustcc commented Jan 24, 2021

冲突了

@visiky
Copy link
Member Author

visiky commented Jan 24, 2021

默认配置改静态方法可以统一一波干掉。

按照现在的方式可否？一个静态的，一个 protected 内部使用（可的话，下一波干掉）

@visiky visiky merged commit 47fa687 into master Jan 24, 2021
@visiky visiky deleted the pie-change-data branch January 24, 2021 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

@lxfu1 lxfu1 Awaiting requested review from lxfu1

@liuzhenying liuzhenying Awaiting requested review from liuzhenying

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visiky @coveralls @hustcc