Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/矩形树图下钻交互新增面包屑 #2386

Merged
merged 3 commits into from
Mar 10, 2021
Merged

Feat/矩形树图下钻交互新增面包屑 #2386

merged 3 commits into from
Mar 10, 2021

Conversation

liuzhenying
Copy link
Member

PR includes

  • add / modify test cases
  • documents, demos

Screenshot

Before After
treemap-drill-interaction treemap-drill-down-with-bread

@liuzhenying liuzhenying requested review from hustcc, visiky and lxfu1 March 3, 2021 02:35
hustcc
hustcc reviewed Mar 9, 2021
View reviewed changes
src/plots/treemap/adaptor.ts Outdated Show resolved Hide resolved
hustcc
hustcc reviewed Mar 9, 2021
View reviewed changes
src/plots/treemap/adaptor.ts Outdated Show resolved Hide resolved
hustcc
hustcc reviewed Mar 9, 2021
View reviewed changes
src/plots/treemap/utils.ts Outdated Show resolved Hide resolved
@liuzhenying
Copy link
Member Author

新增修改：

  • 替换 parsePadding 至 normalPadding，将 normalPadding 函数移动至公共 utlis 方法
  • 增加注释

本地已通过 ci

@liuzhenying liuzhenying requested a review from hustcc March 10, 2021 02:36
@hustcc hustcc merged commit 437170b into master Mar 10, 2021
@hustcc hustcc deleted the feat/treemap_bread branch March 10, 2021 03:05
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Merged
@BenDavisClark
Copy link

第一次渲染矩形树图，点击面包屑下钻，再次数据改变，矩形树图重新渲染，再点击面包屑下钻，面包屑会显示重复，这个怎么解决，怎么重置矩形树图面包屑
Uploading image.png…

@visiky
Copy link
Member

visiky commented Jun 8, 2021 •
edited
Loading

第一次渲染矩形树图，点击面包屑下钻，再次数据改变，矩形树图重新渲染，再点击面包屑下钻，面包屑会显示重复，这个怎么解决，怎么重置矩形树图面包屑

截图破了，有 git 图或者在线 demo 吗（最新版本对交互做了优化，看下是否解决 #2608 ）

@BenDavisClark
Copy link

第一次渲染矩形树图，点击面包屑下钻，再次数据改变，矩形树图重新渲染，再点击面包屑下钻，面包屑会显示重复，这个怎么解决，怎么重置矩形树图面包屑

截图破了，有 git 图或者在线 demo 吗（最新版本对交互做了优化，看下是否解决 #2608 ）

好的，我先更新试一下

@BenDavisClark
Copy link

第一次渲染矩形树图，点击面包屑下钻，再次数据改变，矩形树图重新渲染，再点击面包屑下钻，面包屑会显示重复，这个怎么解决，怎么重置矩形树图面包屑

截图破了，有 git 图或者在线 demo 吗（最新版本对交互做了优化，看下是否解决 #2608 ）

更新完可以了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky Awaiting requested review from visiky

@lxfu1 lxfu1 Awaiting requested review from lxfu1

@hustcc hustcc Awaiting requested review from hustcc

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liuzhenying @BenDavisClark @visiky @hustcc