Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#2572): 修复堆叠分组状图 tooltip 展示不正常 (只展示第一个小分组的数据) #2576

Merged
merged 4 commits into from
May 24, 2021
Merged

fix(#2572): 修复堆叠分组状图 tooltip 展示不正常 (只展示第一个小分组的数据) #2576

merged 4 commits into from
May 24, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented May 22, 2021 •
edited
Loading

先行 G2Plot 处理，后续 G2 5.0 需要注意下 @hustcc

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

Tooltip behavior

  • Default works
  • Formatter works
  • CustomContent works
Before After
image image
image image
image image
增加 tooltip formatter demo image

@visiky visiky requested review from hustcc, liuzhenying and lxfu1 May 22, 2021 00:46
@visiky visiky changed the title fix 2572 fix(#2572): 修复堆叠分组状图 tooltip 展示不正常 (只展示第一个小分组的数据) May 22, 2021
@coveralls
Copy link

coveralls commented May 22, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 865612909

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 96.162%
Files with Coverage Reduction New Missed Lines %
src/utils/transform/word-cloud.ts 1 97.75%
Totals Coverage Status
Change from base Build 859961788: -0.02%
Covered Lines: 5632
Relevant Lines: 5710
💛 - Coveralls

@visiky visiky merged commit 85bbcb2 into master May 24, 2021
@visiky visiky deleted the fix-2572 branch May 24, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

@liuzhenying liuzhenying Awaiting requested review from liuzhenying

@lxfu1 lxfu1 Awaiting requested review from lxfu1

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visiky @coveralls @hustcc