Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circle packing #2655

Merged
merged 8 commits into from
Jun 29, 2021
Merged

Circle packing #2655

merged 8 commits into from
Jun 29, 2021

Conversation

Angelii
Copy link
Contributor

@Angelii Angelii commented Jun 22, 2021

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

Before After
❌ ✅

@coveralls
Copy link

Pull Request Test Coverage Report for Build 959602131

  • 40 of 48 (83.33%) changed or added relevant lines in 5 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 95.687%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/plots/circle-packing/adaptor.ts 17 20 85.0%
src/plots/circle-packing/index.ts 2 7 28.57%
Files with Coverage Reduction New Missed Lines %
src/plots/circle-packing/utils.ts 1 89.06%
src/plots/violin/adaptor.ts 1 95.73%
src/plots/circle-packing/adaptor.ts 5 77.42%
Totals Coverage Status
Change from base Build 918002081: -0.1%
Covered Lines: 6138
Relevant Lines: 6254
💛 - Coveralls

visiky
visiky reviewed Jun 22, 2021
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@visiky visiky changed the base branch from circle-packing to master June 29, 2021 08:05
@visiky visiky merged commit ab4ce2b into antvis:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky visiky approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Angelii @coveralls @visiky