Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2651): when scatter data length = 1 and x is cat #2661

Merged
merged 4 commits into from
Jun 29, 2021

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Jun 28, 2021

@hustcc hustcc force-pushed the fix-scatter-data-lengtgh-1 branch from 7a8d34a to 3514fff Compare June 28, 2021 08:50
@hustcc hustcc changed the title Fix scatter data length 1 fix(#2651): when scatter data length = 1 and x is cat Jun 28, 2021
@hustcc hustcc requested review from visiky and lxfu1 June 28, 2021 08:51
@hustcc
Copy link
Member Author

hustcc commented Jun 28, 2021

  1. transformOption 和 getMeta 功能重复
  2. scatter.type 错误
  3. getMeta 方法简单重构(善用解构语法)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2021

🎊 PR Preview eb8892c has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2661.surge.sh?type=diff&date=2021-06-29

🕐 Build time: 86.062s

🤖 By surge-preview

@coveralls
Copy link

Pull Request Test Coverage Report for Build 978343965

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 95.974%

Files with Coverage Reduction New Missed Lines %
src/utils/transform/word-cloud.ts 1 97.75%
Totals Coverage Status
Change from base Build 968502287: -0.03%
Covered Lines: 6027
Relevant Lines: 6124

💛 - Coveralls

@visiky visiky merged commit dba879a into master Jun 29, 2021
@visiky visiky deleted the fix-scatter-data-lengtgh-1 branch June 29, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants