New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sankey): 修复桑基图 rawFields 在 label & tooltip 处不生效 #2756

Merged

visiky merged 2 commits into master from fix-sankey

Aug 4, 2021

Member

visiky commented Aug 4, 2021 •

edited

Loading

PR includes

fixed 🐛 [BUG] 桑基图，因为内置优先了 callback，导致 formatter 无法设置生效 #2755, 🤔 [QUESTION] 求，桑基图label.callback返回带value相关数据 #2746
add / modify test cases
documents, demos

Screenshot

Before	After
❌	✅


          fix(sankey): 修复桑基图 rawFields 在 label & tooltip 处不生效

25a74d0

pr-triage bot added the PR: unreviewed label


          fix: 修改 lint 问题

91d33aa

Contributor

github-actions bot commented Aug 4, 2021 •

edited

Loading

🎊 PR Preview 91d33aa has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2756.surge.sh?type=diff&date=2021-08-04

🕐 Build time: 74.747s

_{🤖 By surge-preview}

coveralls commented Aug 4, 2021 •

edited

Loading

Pull Request Test Coverage Report for Build 1096645144

7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 95.659%

Totals
Change from base Build 1095804077:	0.004%
Covered Lines:	6318
Relevant Lines:	6437

💛 - Coveralls

visiky merged commit 669f881 into master

visiky deleted the fix-sankey branch

August 4, 2021 07:51

pr-triage bot added PR: merged and removed PR: unreviewed labels

visiky mentioned this pull request

🤔 [QUESTION] 求，桑基图label.callback返回带value相关数据 #2746

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels