feat(venn): 韦恩图颜色回调重构 #2909
Merged
feat(venn): 韦恩图颜色回调重构 #2909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. 修复 color 设置回调，导致图例颜色不正确 2. color 回调参数，增加 defaultColor 默认色 3. 完善韦恩图文档 & 增加 demo
|
🎊 PR Preview 47ea499 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2909.surge.sh?type=diff&date=2021-10-11 🕐 Build time: 120.167s
🤖 By surge-preview |
Pull Request Test Coverage Report for Build 1328169732
💛 - Coveralls |
visiky
commented
Oct 12, 2021
hustcc
approved these changes
Oct 14, 2021
visiky
added a commit
that referenced
this pull request
Oct 14, 2021
* feat(venn): 韦恩图颜色回调重构 1. 修复 color 设置回调，导致图例颜色不正确 2. color 回调参数，增加 defaultColor 默认色 3. 完善韦恩图文档 & 增加 demo * test(venn): 韦恩图单测 fix: #2906 * test(venn): 添加韦恩图 color 单测
visiky
added a commit
that referenced
this pull request
Oct 15, 2021
* feat(venn): 韦恩图颜色回调重构 1. 修复 color 设置回调，导致图例颜色不正确 2. color 回调参数，增加 defaultColor 默认色 3. 完善韦恩图文档 & 增加 demo * test(venn): 韦恩图单测 fix: #2906 * test(venn): 添加韦恩图 color 单测
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes
color: (datum, defaultColor) => defaultColorScreenshot