Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 🎉 Brand new site #19

Merged
merged 65 commits into from
Sep 18, 2019
Merged

refactor: 🎉 Brand new site #19

merged 65 commits into from
Sep 18, 2019

Conversation

afc163
Copy link
Contributor

@afc163 afc163 commented Sep 17, 2019

#18

accesslint[bot]
accesslint bot approved these changes Sep 17, 2019
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@pr-triage pr-triage bot removed the PR: draft label Sep 17, 2019
@netlify
Copy link

netlify bot commented Sep 17, 2019 •
edited
Loading

Deploy preview for hardcore-feynman-614fe6 ready!

Built with commit 2120509

https://deploy-preview-19--hardcore-feynman-614fe6.netlify.com

accesslint[bot]
accesslint bot suggested changes Sep 18, 2019
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

README.md Outdated
![CI status](https://github.com/antvis/antvis.github.io/workflows/Node%20CI/badge.svg)
[![Dependency Status](https://david-dm.org/antvis/antvis.github.io.svg?style=flat-square)](https://david-dm.org/antvis/antvis.github.io)
[![devDependencies Status](https://david-dm.org/antvis/antvis.github.io/dev-status.svg)](https://david-dm.org/antvis/antvis.github.io?type=dev)
![](https://img.shields.io/badge/code_style-prettier-ff69b4.svg?style=flat-square)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

accesslint[bot]
accesslint bot approved these changes Sep 18, 2019
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@afc163 afc163 marked this pull request as ready for review September 18, 2019 06:38
@afc163 afc163 merged commit 84e6e62 into master Sep 18, 2019
@afc163 afc163 deleted the brand-new branch September 30, 2019 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

@accesslint accesslint[bot] accesslint[bot] approved these changes

Assignees
No one assigned
Labels
PR: merged refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@afc163 @simaQ @dxq613 @leungwensen @qjs2000 @ImgBotApp