Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ⚡️ New site with new design #20

Merged
merged 75 commits into from
Oct 14, 2019
Merged

feat: ⚡️ New site with new design #20

merged 75 commits into from
Oct 14, 2019

Conversation

afc163
Copy link
Contributor

@afc163 afc163 commented Sep 18, 2019

#18

@auto-add-label auto-add-label bot added the chore label Sep 18, 2019
@afc163 afc163 changed the title chore: New site with new design chore: ⚡️ New site with new design Sep 18, 2019
@afc163 afc163 changed the title chore: ⚡️ New site with new design feat: ⚡️ New site with new design Sep 18, 2019
@netlify
Copy link

netlify bot commented Sep 18, 2019

Deploy preview for hardcore-feynman-614fe6 ready!

Built with commit 8ecdae2

https://deploy-preview-20--hardcore-feynman-614fe6.netlify.com

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

<input
className={styles.input}
placeholder="Search..."
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

@lgtm-com
Copy link

lgtm-com bot commented Sep 25, 2019

This pull request introduces 1 alert when merging 893f115 into 84e6e62 - view on LGTM.com

new alerts:

  • 1 for Potentially unsafe external link

@lgtm-com
Copy link

lgtm-com bot commented Oct 10, 2019

This pull request introduces 4 alerts when merging 791bcf4 into 84e6e62 - view on LGTM.com

new alerts:

  • 3 for Potentially unsafe external link
  • 1 for Unused variable, import, function or class

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

style={{ width: 90, fontSize: 12 }}
dropdownMatchSelectWidth={false}
value={currentLangKey}
onChange={(value: string) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

@lgtm-com
Copy link

lgtm-com bot commented Oct 10, 2019

This pull request introduces 4 alerts when merging fa7d4d1 into 84e6e62 - view on LGTM.com

new alerts:

  • 3 for Potentially unsafe external link
  • 1 for Unused variable, import, function or class

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

style={{ width: 90, fontSize: 12 }}
dropdownMatchSelectWidth={false}
value={currentLangKey}
onChange={(value: string) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

@lgtm-com
Copy link

lgtm-com bot commented Oct 10, 2019

This pull request introduces 4 alerts when merging b863b16 into 84e6e62 - view on LGTM.com

new alerts:

  • 3 for Potentially unsafe external link
  • 1 for Unused variable, import, function or class

@afc163 afc163 merged commit a17a5ef into master Oct 14, 2019
@afc163 afc163 deleted the new branch October 14, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant