-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ⚡️ New site with new design #20
Conversation
Deploy preview for hardcore-feynman-614fe6 ready! Built with commit 8ecdae2 https://deploy-preview-20--hardcore-feynman-614fe6.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
src/components/search.tsx
Outdated
<input | ||
className={styles.input} | ||
placeholder="Search..." | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.
This pull request introduces 1 alert when merging 893f115 into 84e6e62 - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging 791bcf4 into 84e6e62 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
src/components/header.tsx
Outdated
style={{ width: 90, fontSize: 12 }} | ||
dropdownMatchSelectWidth={false} | ||
value={currentLangKey} | ||
onChange={(value: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.
This pull request introduces 4 alerts when merging fa7d4d1 into 84e6e62 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
src/components/header.tsx
Outdated
style={{ width: 90, fontSize: 12 }} | ||
dropdownMatchSelectWidth={false} | ||
value={currentLangKey} | ||
onChange={(value: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.
This pull request introduces 4 alerts when merging b863b16 into 84e6e62 - view on LGTM.com new alerts:
|
#18