Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated dom-util #307

Merged
merged 2 commits into from
Oct 7, 2023
Merged

chore: remove deprecated dom-util #307

merged 2 commits into from
Oct 7, 2023

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Oct 7, 2023 •
edited
Loading

  • remove deprecated dom-util
  • fix error usage of memoize（纯数学计算不使用 memoize，因为 memoize 本身需要耗时，只有确定场景中重复计算非常频繁）

@hustcc hustcc requested a review from Aarebecca October 7, 2023 11:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6440981183

  • 37 of 37 (100.0%) changed or added relevant lines in 7 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 80.87%
Files with Coverage Reduction New Missed Lines %
src/ui/axis/guides/utils.ts 5 82.35%
Totals Coverage Status
Change from base Build 6440289954: -0.08%
Covered Lines: 7779
Relevant Lines: 8960
💛 - Coveralls

@hustcc hustcc merged commit 72009b5 into master Oct 7, 2023
1 check passed
@hustcc hustcc deleted the remove-dom-util branch October 7, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aarebecca Aarebecca Aarebecca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hustcc @coveralls @Aarebecca