Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use jsdom in ssr #312

Merged
merged 7 commits into from
Nov 12, 2023
Merged

chore: use jsdom in ssr #312

merged 7 commits into from
Nov 12, 2023

Conversation

xiaoiver
Copy link
Contributor

@xiaoiver xiaoiver commented Nov 10, 2023

工程改进:

  • 使用 JSDOM 进行服务端渲染截图并比对,运行速度相较原来 node-canvas 快非常多
  • 移除 node-canvas
  • 升级 Jest 到最新 29.x
  • 移除 OSS 改为上传 diff 截图到 workflow artifacts

另外修复了无法直接服务端渲染的问题,使用 G 内部创建的 offscreencanvas 度量文本

@xiaoiver xiaoiver requested a review from pearmini November 10, 2023 06:54
@xiaoiver xiaoiver requested a review from hustcc November 10, 2023 09:08
@xiaoiver xiaoiver merged commit bb09ef5 into master Nov 12, 2023
2 checks passed
@xiaoiver xiaoiver deleted the test-jsdom branch November 12, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant