Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gague,pie,ring-progress,liquid 等 changedata 触发钩子事件 #2319

Merged
merged 2 commits into from
Feb 23, 2021
Merged

fix: gague,pie,ring-progress,liquid 等 changedata 触发钩子事件 #2319

merged 2 commits into from
Feb 23, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Feb 8, 2021 •
edited
Loading

PR includes

todo list

  • liquid
  • pie
  • ring-progress and so on

Screenshot

Before After
❌ ✅

@visiky visiky requested a review from hustcc February 8, 2021 03:44
@visiky visiky linked an issue Feb 8, 2021 that may be closed by this pull request
plot.on事件触发问题 #2260
Closed
@visiky visiky mentioned this pull request Feb 8, 2021
Merged
3 tasks
@visiky
Copy link
Member Author

visiky commented Feb 8, 2021

ref: antvis/G2#3281

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2021 •
edited
Loading

😭 Deploy PR Preview 53b0965 failed. Build logs

🤖 By surge-preview

hustcc
hustcc reviewed Feb 8, 2021
View reviewed changes
src/plots/gauge/index.ts Outdated Show resolved Hide resolved
@hustcc
Copy link
Member

hustcc commented Feb 10, 2021

修改没有问题：

  1. 等 G2 发包，使用 export 的出来的变量
  2. 其他图形类似修改

@visiky visiky added WIP and removed WIP labels Feb 10, 2021
@visiky visiky changed the title gauge changedata fix: gague,pie,ring-progress,liquid 等 changedata 触发钩子事件 Feb 12, 2021
@visiky
Copy link
Member Author

visiky commented Feb 12, 2021

依赖：antvis/G2#3288

@coveralls
Copy link

Pull Request Test Coverage Report for Build 591932137

  • 18 of 18 (100.0%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 96.631%
Files with Coverage Reduction New Missed Lines %
src/plots/pie/index.ts 2 85.71%
Totals Coverage Status
Change from base Build 587650183: 0.006%
Covered Lines: 4944
Relevant Lines: 4997
💛 - Coveralls

@visiky visiky merged commit 8bf5a6a into master Feb 23, 2021
@visiky visiky deleted the gauge-changedata branch February 23, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plot.on事件触发问题
3 participants
@visiky @hustcc @coveralls