upd: update cors rules in aws-anyscale-s3 module #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With some upcoming changes to the Anyscale Web Console, there are changes for the CORS rules for the S3 bucket. This update also includes a change to tag the S3 bucket with cloud id if provided. On branch brent/update-cors Changes to be committed: modified: modules/aws-anyscale-s3/README.md modified: modules/aws-anyscale-s3/main.tf modified: modules/aws-anyscale-s3/variables.tf
Upcoming features requre additional CORS policy for the Anyscale S3 bucket. Additional cleanup work done on the aws-anyscale-s3 unit tests, removing the unused Go unit tests. Changes to be committed: modified: modules/aws-anyscale-s3/README.md modified: modules/aws-anyscale-s3/test/README.md deleted: modules/aws-anyscale-s3/test/go.mod deleted: modules/aws-anyscale-s3/test/go.sum deleted: modules/aws-anyscale-s3/test/terraform_aws_anyscale_s3_test.go modified: modules/aws-anyscale-s3/variables.tf
sudhirn-anyscale
approved these changes
Feb 4, 2024
This will support additional functionality for the Anyscale UI including updated dependency management for Anyscale clusters. Additional updates to E2E tests Changes to be committed: modified: modules/aws-anyscale-s3/README.md modified: modules/aws-anyscale-s3/variables.tf new file: test/anyscale-v2-e2e-public-services-test/main.tf new file: test/anyscale-v2-e2e-public-services-test/outputs.tf new file: test/anyscale-v2-e2e-public-services-test/variables.tf new file: test/anyscale-v2-e2e-public-services-test/versions.tf modified: test/test_cloud_register_manual.py
hckuo
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some upcoming changes to the Anyscale Web Console,
there are changes for the CORS rules for the S3 bucket.
Additional cleanup work done on the aws-anyscale-s3 unit tests, removing the
unused Go unit tests.
Changes to be committed:
modified: modules/aws-anyscale-s3/README.md
modified: modules/aws-anyscale-s3/test/README.md
deleted: modules/aws-anyscale-s3/test/go.mod
deleted: modules/aws-anyscale-s3/test/go.sum
deleted: modules/aws-anyscale-s3/test/terraform_aws_anyscale_s3_test.go
modified: modules/aws-anyscale-s3/variables.tf
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull Request Type
Does this introduce a breaking change?