upd: aws-anyscale-s3-policy module to support custom policies #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom policies were not being passed from the root module to the sub-module. This change adds the ability to pass in custom modules from the root module. Additional updates include a large rewrite of the s3-policy module to include: - Pre-defined S3 Policy template file - Renamed variables to be more descriptive - Reworked examples/tests Lastly, this also includes an updated kitchensink example to show how to use the custom policy feature. On branch brent/update-s3policy Changes to be committed: modified: .pre-commit-config.yaml modified: README.md modified: examples/anyscale-v2-kitchensink/README.md modified: examples/anyscale-v2-kitchensink/main.tf modified: examples/anyscale-v2-kitchensink/variables.tf modified: main.tf modified: modules/aws-anyscale-s3-policy/README.md deleted: modules/aws-anyscale-s3-policy/examples/README.md modified: modules/aws-anyscale-s3-policy/examples/main.tf modified: modules/aws-anyscale-s3-policy/examples/outputs.tf modified: modules/aws-anyscale-s3-policy/examples/variables.tf modified: modules/aws-anyscale-s3-policy/main.tf new file: modules/aws-anyscale-s3-policy/predefined_s3_policy.tpl modified: modules/aws-anyscale-s3-policy/test/README.md deleted: modules/aws-anyscale-s3-policy/test/anyscale-test/main.tf deleted: modules/aws-anyscale-s3-policy/test/anyscale-test/outputs.tf deleted: modules/aws-anyscale-s3-policy/test/anyscale-test/variables.tf deleted: modules/aws-anyscale-s3-policy/test/anyscale-test/versions.tf modified: modules/aws-anyscale-s3-policy/variables.tf
github-actions
bot
added
documentation
hongchaodeng
approved these changes
Oct 7, 2024
It's in the release notes, and bolded at the top. Any concerns with that?
|
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom policies were not being passed from the root module to the sub-module. This change adds the ability to pass in custom modules from the root module.
This may replace the existing S3 Policy on the Anyscale S3 bucket
Additional updates include a large rewrite of the s3-policy module to include:
Lastly, this also includes an updated kitchensink example to show how to use the custom policy feature.
On branch brent/update-s3policy
Changes to be committed:
modified: .pre-commit-config.yaml
modified: README.md
modified: examples/anyscale-v2-kitchensink/README.md
modified: examples/anyscale-v2-kitchensink/main.tf
modified: examples/anyscale-v2-kitchensink/variables.tf
modified: main.tf
modified: modules/aws-anyscale-s3-policy/README.md
deleted: modules/aws-anyscale-s3-policy/examples/README.md
modified: modules/aws-anyscale-s3-policy/examples/main.tf
modified: modules/aws-anyscale-s3-policy/examples/outputs.tf
modified: modules/aws-anyscale-s3-policy/examples/variables.tf
modified: modules/aws-anyscale-s3-policy/main.tf
new file: modules/aws-anyscale-s3-policy/predefined_s3_policy.tpl
modified: modules/aws-anyscale-s3-policy/test/README.md
deleted: modules/aws-anyscale-s3-policy/test/anyscale-test/main.tf
deleted: modules/aws-anyscale-s3-policy/test/anyscale-test/outputs.tf
deleted: modules/aws-anyscale-s3-policy/test/anyscale-test/variables.tf
deleted: modules/aws-anyscale-s3-policy/test/anyscale-test/versions.tf
modified: modules/aws-anyscale-s3-policy/variables.tf
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull Request Type
Does this introduce a breaking change?
This may replace the S3 policy on the existing S3 bucket