Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0: Runtime: Core BPF Migration: Add checks for executable program account (backport of #2483) #2516

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 8, 2024

Problem

When the Core BPF migration module was being added to the runtime, the executable flag for accounts was being deprecated, so checks for this flag were not added to the mechanisms for migrating and upgrading Core BPF programs. See #309.

These changes were reverted, and the Core BPF migration code must be aware of the executable flag on accounts.

Additionally, even though the program can still be invoked via instruction, the program account must be set as executable when performing a migration, to ensure all executable flag checks are successful on the new program.

Summary of Changes

Two small changes:

#2483)

* Runtime: Core BPF: check `executable` on program load

* Runtime: Core BPF: set `executable` on migration

(cherry picked from commit 33119c5)
@mergify mergify bot requested a review from a team as a code owner August 8, 2024 22:27
@buffalojoec
Copy link

Requesting backport to 2.0 to ensure any upcoming feature gates to migrate programs will allow those programs to have the executable flag set to the expected value post-migration. Note: These feature gates are not yet scheduled.

@buffalojoec buffalojoec requested a review from 2501babe August 13, 2024 12:13
@buffalojoec buffalojoec merged commit e00d83b into v2.0 Aug 19, 2024
39 checks passed
@buffalojoec buffalojoec deleted the mergify/bp/v2.0/pr-2483 branch August 19, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants