Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract rpc response crate (attempt 2) #2961

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kevinheavey
Copy link

Made a mess of #2084 in a rebase, easier to make a new PR.

Problem

It would be great to import RPC response parsing code without relying on the request-building code - it it not uncommon to want one without the other. Pulling out the response-parsing code allows you to avoid the jsonrpc-core and reqwest dependencies, which are very heavy.

Summary of Changes

Move solana_rpc_client_api::response (except for the RpcResult alias) to its own crate, and re-export for backwards compatibility.

Copy link

mergify bot commented Sep 22, 2024

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/web3.js (example)

Thank you for keeping the RPC clients in sync with the server API @kevinheavey.

@kevinheavey kevinheavey force-pushed the extract-rpc-response2 branch 2 times, most recently from dc894fe to 2d46f67 Compare October 29, 2024 08:37
@kevinheavey kevinheavey force-pushed the extract-rpc-response2 branch 3 times, most recently from ec4dc44 to 4a3ed0f Compare November 19, 2024 14:38
@kevinheavey kevinheavey force-pushed the extract-rpc-response2 branch 2 times, most recently from 8b326a0 to 1c4a2a4 Compare December 4, 2024 19:04
@kevinheavey kevinheavey force-pushed the extract-rpc-response2 branch from 1c4a2a4 to 3d1fea4 Compare December 10, 2024 12:16
@kevinheavey kevinheavey force-pushed the extract-rpc-response2 branch from 336e80a to 9aa3854 Compare December 17, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant