Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test --enable-extended-tx-metadata-storage in run-sanity.sh #3864

Merged

Conversation

ryoqun
Copy link
Member

@ryoqun ryoqun commented Dec 2, 2024

follow up to #3861

locally confirmed this can detect the bug fixed by the pr #3861

@ryoqun ryoqun requested a review from apfitzge December 2, 2024 14:41
@ryoqun ryoqun force-pushed the ledger-tool-transaction-status-sender-tests branch from fe9c3a1 to 790b274 Compare December 2, 2024 14:44
@ryoqun ryoqun requested a review from apfitzge December 2, 2024 15:20
@ryoqun ryoqun merged commit 6a867ad into anza-xyz:master Dec 2, 2024
20 checks passed
Copy link

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this could not have been a unit test in the ledger-tool crate ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants