-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only permit X25519 based QUIC-TLS key exchanges #3927
base: master
Are you sure you want to change the base?
Conversation
d4fdee7
to
ca2aabb
Compare
ca2aabb
to
acc6022
Compare
Did we do any cross version compatibility test? Like if an older version of the agave-client talks to the server with this change, does it still work? |
I didn't do any specific version compatibility tests. But I'm certain that this change does not introduce compatibility issues. |
I expect it work as well. But we still need to do due diligence testing. I am not sure about coverage of invalidator testing on backward compatibility on this regard. I will launch a GCE cluster and see how it goes |
Hi @ripatel-fd could you please rebase with master? Somehow GitHub does not enable to fix the conflict on this PR directly. Sorry -- it took me some time to turn around to run the test: I ran old code cluster and use this code as client -- worked as expected |
Problem
Some versions of Agave permit a variety of key exchange algorithms.
These increase cryptographic attack surface and are slower than X25519.
Summary of Changes
Reject connection requests with key exchange algorithms other than X25519.
Fixes #