Define BankingTracer::create_channels() #4041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
ryoqun
commented
Dec 10, 2024
| self.create_channel(ChannelLabel::TpuVote) | ||
| } | ||
|
|
||
| pub fn create_channel_gossip_vote(&self) -> (BankingPacketSender, BankingPacketReceiver) { | ||
| fn create_channel_gossip_vote(&self) -> (BankingPacketSender, BankingPacketReceiver) { | ||
| self.create_channel(ChannelLabel::GossipVote) | ||
| } |
There was a problem hiding this comment.
these fns are now private
|
@apfitzge ping :) |
apfitzge
reviewed
Dec 12, 2024
core/src/banking_trace.rs
Outdated
| @@ -220,22 +230,85 @@ impl BankingTracer { | |||
| self.active_tracer.is_some() | |||
| } | |||
|
|
|||
| pub fn create_channels(&self, pool: Option<&Arc<DefaultSchedulerPool>>) -> Channels { | |||
There was a problem hiding this comment.
neat - I actually wanted to experiment with this in central-scheduler as well. Now I don't have to do the work 😄
There was a problem hiding this comment.
given that, can we just make this take a bool?
unified-scheduler can have this always be true (Option::is_some) and for central-scheduler can control via some sort of configuration.
apfitzge
reviewed
Dec 12, 2024
There was a problem hiding this comment.
See https://github.com/anza-xyz/agave/pull/4041/files#r1882325321
Otherwise, love the change
ha. was literally typing my comments as you pinged me 😆 |
apfitzge
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
unified scheduler wants to treat all the transactions as same.
Summary of Changes
Unify the incoming channels for the banking stage conditionally. Currently stubbed.
No functional change, so no test is added.
extracted from #3946, see the pr for the general overview.