gossip: Add save_contact_info_time metric
#4114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadorovsky
force-pushed
the
sol-gossip-loop-metric
branch
from
5c2600c to
52aef03
Compare
gregcusack
reviewed
Dec 17, 2024
gossip/src/cluster_info_metrics.rs
Outdated
Comment on lines
571
to
575
| ( | ||
| "save_contact_info_time", | ||
| stats.save_contact_info_time.clear(), | ||
| i64 | ||
| ), |
There was a problem hiding this comment.
nit: I would put this under cluster_info_stats2 since there are more timing metrics there and cluster_info_stats5 is more packet/count related
Add `save_contact_info_time` metric which measures the time spent by the `solGossip` thread on fetching and saving contact info.
vadorovsky
force-pushed
the
sol-gossip-loop-metric
branch
from
52aef03 to
a180e52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
save_contact_info_timemetric which measures the time spent by thesolGossipthread on fetching and saving contact info.