-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SOL] Remove LE byte swap and input buffers #75
[SOL] Remove LE byte swap and input buffers #75
Conversation
b482fc6
to
cb1f186
Compare
SBF_B = 0x2, | ||
SBF_DW = 0x3 | ||
}; | ||
enum SBF_SIZE { SBF_W = 0x0, SBF_H = 0x1, SBF_B = 0x2, SBF_DW = 0x3 }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ordinarily, re-formatting should only be done within the parts of the code changed in the patch itself.
See https://llvm.org/docs/DeveloperPolicy.html:
Avoid committing formatting- or whitespace-only changes outside of code you plan to make subsequent changes to. Also, try to separate formatting or whitespace changes from functional changes, either by correcting the format first (ideally) or afterward. Such changes should be highly localized and the commit message should clearly state that the commit is not intended to change functionality, usually by stating it is NFC.
This time, just go ahead and leave as is, but do become familiar with the above link and practices. Note that there are many formatting problems in the code that we inherited. They were originally left as is to facilitate upstream merges. That may be less important now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a coding standard / patch etiquette nit mentioned, the patch is as we discussed offline and LGTM.
b164627
into
anza-xyz:solana-rustc/16.0-2023-06-05
This PR addressed two more items in solana-labs/solana#34250. It removes the little endian byte swap instructions (solana-labs/rbpf#493) and the input buffers related instructions (solana-labs/rbpf#251).
This PR addressed two more items in solana-labs/solana#34250. It removes the little endian byte swap instructions (solana-labs/rbpf#493) and the input buffers related instructions (solana-labs/rbpf#251).
This PR addressed two more items in solana-labs/solana#34250. It removes the little endian byte swap instructions (solana-labs/rbpf#493) and the input buffers related instructions (solana-labs/rbpf#251).
This PR addressed two more items in solana-labs/solana#34250. It removes the little endian byte swap instructions (solana-labs/rbpf#493) and the input buffers related instructions (solana-labs/rbpf#251).
This PR represents the two more task in solana-labs/solana#34250. It removes the little endian byte swap instructions (solana-labs/rbpf#493) and the input buffers related instructions (solana-labs/rbpf#251).