Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions files #5

Merged
merged 16 commits into from
Dec 16, 2024
Merged

Conversation

vietnguyengit
Copy link
Collaborator

No description provided.

@vietnguyengit vietnguyengit marked this pull request as draft December 10, 2024 02:41
@vietnguyengit vietnguyengit marked this pull request as ready for review December 16, 2024 03:33
Copy link
Contributor

@utas-raymondng utas-raymondng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that the deploy.yml add later? I see the call to use this yml

@vietnguyengit
Copy link
Collaborator Author

trigger_deploy.yml is the only one as in es-indexer, trigger_deploy action will call the stuff in appdeploy system @utas-raymondng , there is condition to run trigger_deploy.yml action as well, which only after build completes, please ignore the history action runs, I have them ran with force condition to run on "PR" to main. that has been removed. Only linting steps to run in PR

Copy link
Contributor

@utas-raymondng utas-raymondng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utas-raymondng utas-raymondng merged commit 14dc8f0 into main Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants