Adcp updates #772
Closed
Adcp updates #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of some PP routines, auto QC routines for RDI single-ping data processing.
Note that there still is a bug that needs fixing in the process: when the correlation magnitude and echo range PP routines are run, the flags created are not carried through to the ensemble averaging step. The PP flow manager does not retain the flags in the same way that the autoQC flow manager does.
This means although the CMAG and EchoRange PP tests function, their results do not get considered in the conversion from BEAM to ENU, and the three-beam solutions does not get engaged correctly.