Nortek adcp4beams mark #784
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... as reference. Not called by imos toolbox.
Include Signature55 case and file acquisition from *.ad2cp file type. Add Beam2xyz sub function.
1. moved functions in +Nortek/ including tests and description 2. Fix regex in read_header_key.m linked to #758 3. Include Signature100 case and include error message when the SIgnature is not supported 4. updated signatureParse description as it can read both .ad2cp and .mat 5. Other clean up
evacougnon
force-pushed
the
NortekADCP4beams_Mark
branch
from
b9858dd to
2dfb513
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
@lbesnard this is the branch I'm using to include the update from this PR: #778
So far, I only looked at the parser but I still need to add the tests and clean up the license bit based on the wiki
The test I added there is commented out as I could not test Parser/testSignature.m as I don't have a small enough sig55 file.