Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/5772 paging #77

Merged
merged 7 commits into from
Aug 20, 2024
Merged

Features/5772 paging #77

merged 7 commits into from
Aug 20, 2024

Conversation

utas-raymondng
Copy link
Collaborator

@utas-raymondng utas-raymondng commented Aug 16, 2024 •
edited
Loading

  1. Allow paging with page_size
  2. Allow search_after so that we can go to a particular starting point
  3. Return total record hit

HavierD
HavierD approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@HavierD HavierD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@HavierD HavierD merged commit 31fe1ee into main Aug 20, 2024
2 checks passed
@HavierD HavierD deleted the features/5772-paging branch August 20, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HavierD HavierD HavierD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utas-raymondng @HavierD