Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features/platform and organisation vocabs search #83

Merged
merged 16 commits into from
Sep 6, 2024

Conversation

vietnguyengit
Copy link
Collaborator

No description provided.

@vietnguyengit vietnguyengit marked this pull request as draft August 28, 2024 00:35
@vietnguyengit vietnguyengit changed the title Platform vocabs stuff Platform and organisation vocabs implementation (consuming data from Elastic Search's vocabs index) Aug 29, 2024
@vietnguyengit vietnguyengit marked this pull request as ready for review September 2, 2024 22:48
@vietnguyengit
Copy link
Collaborator Author

Ah wrong one, this one not ready yet

@vietnguyengit vietnguyengit marked this pull request as draft September 2, 2024 23:10
@vietnguyengit vietnguyengit marked this pull request as ready for review September 3, 2024 16:42
Copy link
Collaborator

@utas-raymondng utas-raymondng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, and please name your branch with either features/ bugs/ testing/ then follow by ticket id and then a description

bugs/2342-fix-buid-issue etc

I approve this ticket and please do not forget to update appDeploy if needed

parameter_vocab:
path: parameter_vocab
field: label
search_suggestions:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it will be straight forward to rename a remote branch than already has a reviewed PR, I might just rename the PR name this time.

@vietnguyengit vietnguyengit changed the title Platform and organisation vocabs implementation (consuming data from Elastic Search's vocabs index) features/platform and organisation vocabs search Sep 6, 2024
@vietnguyengit vietnguyengit merged commit 0c9f8d2 into main Sep 6, 2024
2 checks passed
@vietnguyengit vietnguyengit deleted the platform-vocabs-stuff branch September 6, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants