Skip to content

Commit

Permalink
Bug 1758114 [wpt PR 33057] - Remove DCHECKs in FloatRoundedRect::Radi…
Browse files Browse the repository at this point in the history
…i::Expand(), a=testonly

Automatic update from web-platform-tests
Remove DCHECKs in FloatRoundedRect::Radii::Expand()

The DCHECK failed when we calculated the inner bounds of an outline
with border-radius, if the outline had big negative outline-offset
and was on a box whose size was bigger than 2x outline width in one
dimension and smaller than 2x outline width in the other dimension.
In the case, FloatRoundedRect::Radii::Expand() was called with a
gfx::OutsetsF with mixed positive/negative components.

Remove the DCHECK as the case is valid. Will follow up for refactors
and cleanups.

Bug: 1301077
Change-Id: Id76b5587b83a6fd0c8fbf0dcea010dc1670f7c58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3499896
Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/main@{#977654}

--

wpt-commits: 6d14c7abcf06b236d76088acabc5d8cae83085eb
wpt-pr: 33057
  • Loading branch information
wangxianzhu authored and moz-wptsync-bot committed Mar 21, 2022
1 parent 85ad814 commit bcb3246
Showing 1 changed file with 12 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<!doctype html>
<link rel="help" href="https://drafts.csswg.org/css-ui/#outline-offset">
<link rel="help" href="https://crbug.com/1301077">
<style>
#target {
width: 100px;
height: 10px;
border-radius: 10px;
outline: 20px solid green;
outline-offset: -200px;
</style>
<div id="target"></div>

0 comments on commit bcb3246

Please sign in to comment.