[chrome.ffmpeg] don't set toolchain_level forcely #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original reason that AndroidApiLevels could not get correct level is due to android-ndk-ci didn't contain sysroot files for api-level 24. After hacking the android-ndk-ci and adding api-level 24 lib files, the build_ffmpeg.py can work. Updated some auto-generated files together with this change. Note, we now have to use https://github.com/aosp-riscv/android-ndk-ci, but not https://github.com/aosp-riscv/toolchain-prebuilts-ndk-r23 when running running build_ffmpeg.py. Because this script will use clang tools contained in the android ndk to build some files, but the android ndk from T-head can not work well, so I have to use android-ndk-ci(which actually use the clang we build ourselves) instead and it works for us. I don't want to hack the android ndk from T-head because there are too many mess for ndk. Hopeing android ndk to be ready soon so we will not have so many troubles when porting chromium. I will update the document to point this out. Signed-off-by: Wang Chen <wangchen20@iscas.ac.cn>
|
Changes for android-ndk-ci is merged with aosp-riscv/android-ndk-ci#3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original reason that AndroidApiLevels could not get correct level is due to android-ndk-ci didn't contain sysroot files for api-level 24. After hacking the android-ndk-ci and adding api-level 24 lib files, the build_ffmpeg.py can work.
Updated some auto-generated files together with this change.
Note, we now have to use https://github.com/aosp-riscv/android-ndk-ci, but not https://github.com/aosp-riscv/toolchain-prebuilts-ndk-r23 when running running build_ffmpeg.py. Because this script will use clang tools contained in the android ndk to build some files, but the android ndk from T-head can not work well, so I have to use android-ndk-ci(which actually use the clang we build ourselves) instead and it works for us.
I don't want to hack the android ndk from T-head because there are too many mess for ndk. Hopeing android ndk to be ready soon so we will not have so many troubles when porting chromium. I will update the document to point this out.