Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

feat: add properties for font sizing #10

Merged
merged 4 commits into from
Mar 12, 2019

Conversation

khtruong
Copy link
Contributor

@khtruong khtruong commented Mar 8, 2019

🏆 Enhancements

We want to allow small customizations for Big Number at Lyft. A small one would be font sizing. There are others such as color and alignment but I am sending out a small one for font sizing first.

I added two properties to allow the ability to size the big number and its subheader. Below are screenshots:

Big Number Tiny Font Size

Big Number Small Font Size

Default Font Sizes

Big Number Large Font Size

Big Number Huge Font Size

@khtruong khtruong requested a review from a team as a code owner March 8, 2019 22:50
@khtruong
Copy link
Contributor Author

khtruong commented Mar 8, 2019

:eyes @kristw @xtinec @williaster

Copy link
Collaborator

@kristw kristw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm. Only revert the package number back.
Also, how does it look like for the big number with trendline?

@khtruong
Copy link
Contributor Author

khtruong commented Mar 8, 2019

Overall lgtm. Only revert the package number back.
Also, how does it look like for the big number with trendline?

Big number with trendline looks similar.

Big Number With Trendline

@kristw
Copy link
Collaborator

kristw commented Mar 9, 2019

Great. Not sure what is going on with Travis. Will wait a bit to see if it figures itself out.

@kristw kristw closed this Mar 9, 2019
@kristw kristw reopened this Mar 9, 2019
@kristw
Copy link
Collaborator

kristw commented Mar 9, 2019

c'mon travis!

Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🤞travis

@khtruong
Copy link
Contributor Author

@williaster Here is how it looks with the largest font for the subheader. Let me know if you want more screenshots.
Screen Shot 2019-03-11 at 10 19 06 AM

@williaster
Copy link
Contributor

thanks for the screenshot, I actually meant largest font with trendline since that is theoretically the "most-filled" variation.

@khtruong
Copy link
Contributor Author

thanks for the screenshot, I actually meant largest font with trendline since that is theoretically the "most-filled" variation.

Sorry about that! Here's the screenshot.
Screen Shot 2019-03-11 at 11 36 27 AM

@xtinec
Copy link
Contributor

xtinec commented Mar 12, 2019

@khtruong mentioned that travis is stuck and @kristw and @williaster are cool with merging the PR as-is, so I'm going to go ahead and merge. 🙂

@xtinec xtinec merged commit d07f60c into apache-superset:master Mar 12, 2019
@kristw kristw added this to the v0.10.1 milestone Mar 14, 2019
@kristw kristw added the #bug Something isn't working label Mar 14, 2019
nytai referenced this pull request in preset-io/superset-ui-plugins Apr 27, 2020
* feat: add properties for font sizing

* revert package.json changes

* refactor: rename bigNum to header

* chore: empty commit to kick off travis
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
#bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants