-
Notifications
You must be signed in to change notification settings - Fork 77
Conversation
:eyes @kristw @xtinec @williaster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm. Only revert the package number back.
Also, how does it look like for the big number with trendline?
packages/superset-ui-legacy-preset-chart-big-number/package.json
Outdated
Show resolved
Hide resolved
Great. Not sure what is going on with Travis. Will wait a bit to see if it figures itself out. |
c'mon travis! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! 🤞travis
@williaster Here is how it looks with the largest font for the subheader. Let me know if you want more screenshots. |
thanks for the screenshot, I actually meant largest font with trendline since that is theoretically the "most-filled" variation. |
@khtruong mentioned that travis is stuck and @kristw and @williaster are cool with merging the PR as-is, so I'm going to go ahead and merge. 🙂 |
* feat: add properties for font sizing * revert package.json changes * refactor: rename bigNum to header * chore: empty commit to kick off travis
🏆 Enhancements
We want to allow small customizations for Big Number at Lyft. A small one would be font sizing. There are others such as color and alignment but I am sending out a small one for font sizing first.
I added two properties to allow the ability to size the big number and its subheader. Below are screenshots: