feat(plugin-chart-table): add small number formatter #1028
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/5KPm1nizLVGomDPcH3vWNjUB5cvR |
Codecov Report
@@ Coverage Diff @@
## master #1028 +/- ##
==========================================
+ Coverage 27.69% 27.74% +0.05%
==========================================
Files 427 427
Lines 8746 8758 +12
Branches 1311 1314 +3
==========================================
+ Hits 2422 2430 +8
- Misses 6151 6155 +4
Partials 173 173
Continue to review full report at Codecov.
|
| if (this.formatter === String) { | ||
| return String(this.input); | ||
| } | ||
| return this.formatter ? this.formatter(this) : Date.toString.call(this); |
There was a problem hiding this comment.
While this code works in production, somehow it doesn't work in the dev mode of Storybook. Moving to instance in constructor to make sure it works in both cases.
|
@kristw do you mind stamping this as well? |
ktmud
force-pushed
the
table-column-formatting
branch
from
111be2a to
10b5035
Compare
…#1028) * feat(plugin-chart-table): add small number formatter * Fix basic storybook
🐛 Bug Fix
Realized I didn't commit the changes about small number formatter before merging... #1019