Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(chart-controls): export/import DTTM_ALIAS properly #1035

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

ktmud
Copy link
Contributor

@ktmud ktmud commented Mar 30, 2021

🐛 Bug Fix

Fixes a bad import introduced by #1019

See #1034 (comment) for details

@ktmud ktmud requested a review from a team as a code owner March 30, 2021 16:00
@vercel
Copy link

vercel bot commented Mar 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/FTTpSbrpyZcEMbfHRsfpUBHdeKg9
✅ Preview: https://superset-ui-git-export-dttm-alias-superset.vercel.app

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #1035 (9ddfe6e) into master (6f5e753) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1035   +/-   ##
=======================================
  Coverage   27.74%   27.74%           
=======================================
  Files         427      428    +1     
  Lines        8758     8758           
  Branches     1314     1314           
=======================================
  Hits         2430     2430           
  Misses       6155     6155           
  Partials      173      173           
Impacted Files Coverage Δ
...ckages/superset-ui-chart-controls/src/constants.ts 100.00% <ø> (ø)
...ges/superset-ui-core/src/query/buildQueryObject.ts 100.00% <ø> (ø)
...s/superset-ui-core/src/query/extractQueryFields.ts 100.00% <ø> (ø)
packages/superset-ui-core/src/query/constants.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5e753...9ddfe6e. Read the comment docs.

Copy link
Contributor

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm

@ktmud ktmud merged commit 152eb86 into master Mar 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the export-dttm-alias branch March 30, 2021 16:44
NejcZdovc pushed a commit to blotoutio/superset-ui that referenced this pull request Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants